refactor: move API key input into Cohere and NVIDIA rerank components #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove generic API key input from base compressor model and add specific API key inputs for Cohere and NVIDIA Rerank components
dosubot
bot
added
the
size:S
edwinjosechittilappilly
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
LGTM.
@ogabrielluiz Should we follow the same in upcoming PRs also?
|
Yes. This was mainly because the specific field came from a parent class causing the NVIDIA component and Cohere components to not be included when you add a Global Variable to the field (e.g |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the API key input from the base compressor model to the specific Cohere and NVIDIA Rerank components, enhancing clarity and specificity in the input handling.