Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: updated ChatOutput component that can accept Data, Dataframe and Message #6643

Merged
merged 19 commits into from
Feb 19, 2025

Conversation

edwinjosechittilappilly
Copy link
Collaborator

This pull request includes several changes to the ChatOutput component to enhance its functionality and improve data handling. The most important changes include the addition of new input types, a new input field for data cleaning, and improved data conversion and validation methods.

Enhancements to ChatOutput component:

  • Added new input types Data and DataFrame to the input_value field, allowing for more flexible data handling. [1] [2] [3]
  • Introduced a new BoolInput field named clean_data to enable basic data cleaning operations. [1] [2] [3]
  • Replaced MessageInput with HandleInput for the input_value field to support multiple input types and ensure that the field is required. [1] [2]
  • Enhanced the message_response method to include data conversion to string and updated message properties handling. [1] [2]
  • Added new methods _validate_input, _safe_convert, and convert_to_string to validate and safely convert input data to string format, ensuring proper error handling.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 15, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 16, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

Needs better testing Cause this is a major change.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
@edwinjosechittilappilly
Copy link
Collaborator Author

@Cristhianzl can you take a look into the frontend tests?

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #6643 will not alter performance

Comparing feat_new_chat_output (4761369) with main (e970cdb)

Summary

✅ 14 untouched benchmarks

@ogabrielluiz
Copy link
Contributor

@edwinjosechittilappilly The problem relates to the starter projects updates. The tests are expecting something that they are not finding because something changed the starter projects.

@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 19, 2025
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 69df913 Feb 19, 2025
35 checks passed
@ogabrielluiz ogabrielluiz deleted the feat_new_chat_output branch February 19, 2025 17:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants