Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: handle null and boolean correctly on table parameter #6722

Merged
merged 10 commits into from
Feb 24, 2025

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes significant changes to the backend and frontend code to improve the handling of table schemas and rendering components. The most important changes include updates to the Column class to support new data types, enhancements to the table rendering logic, and the addition of a new toggle cell editor component.

Backend Changes:

  • src/backend/base/langflow/schema/table.py: Updated the Column class to support new data types (bool, int, float) for the default field and added a new type field. Implemented a set_formatter_from_type method to set the formatter based on the type and convert default values accordingly. [1] [2]

Frontend Changes:

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 19, 2025
@lucaseduoli lucaseduoli self-assigned this Feb 19, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 19, 2025
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 24, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
Copy link

codspeed-hq bot commented Feb 24, 2025

CodSpeed Performance Report

Merging #6722 will degrade performances by 21.69%

Comparing fix/handling_null_values (dbed947) with main (05935ed)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 11.3 ms 14.4 ms -21.69%

…ponent to use new methods for interacting with elements and improve readability and maintainability of the test code.
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 24, 2025
@lucaseduoli lucaseduoli added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit 3257c57 Feb 24, 2025
37 checks passed
@lucaseduoli lucaseduoli deleted the fix/handling_null_values branch February 24, 2025 22:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants