-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: handle null and boolean correctly on table parameter #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cristhianzl
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CodSpeed Performance ReportMerging #6722 will degrade performances by 21.69%Comparing Summary
Benchmarks breakdown
|
…ponent to use new methods for interacting with elements and improve readability and maintainability of the test code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the backend and frontend code to improve the handling of table schemas and rendering components. The most important changes include updates to the
Column
class to support new data types, enhancements to the table rendering logic, and the addition of a new toggle cell editor component.Backend Changes:
src/backend/base/langflow/schema/table.py
: Updated theColumn
class to support new data types (bool
,int
,float
) for thedefault
field and added a newtype
field. Implemented aset_formatter_from_type
method to set the formatter based on the type and convert default values accordingly. [1] [2]Frontend Changes:
src/frontend/src/components/core/parameterRenderComponent/components/TableNodeComponent/index.tsx
: Added grid options to ensure DOM order and suppress row click selection.src/frontend/src/components/core/parameterRenderComponent/components/tableComponent/components/tableAutoCellRender/index.tsx
: Extended theformatter
options to includeboolean
,number
,undefined
, andnull
. Added rendering logic for these new types. [1] [2]src/frontend/src/components/core/parameterRenderComponent/components/tableComponent/components/tableToggleCellEditor/index.tsx
: Introduced a newTableToggleCellEditor
component to handle boolean values with a toggle switch.src/frontend/src/utils/utils.ts
: Updated theFormatColumns
function to handle the newboolean
formatter and configure the appropriate cell renderer and editor.