fix: updated ChatOutput component not working with streaming enabled #6747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angflow-ai#6744) fixes: 69df913 Updated to handle the forgotten Generator case for self.input_value (encountered when streaming is enabled). Overhauled the chat.py under outputs to (mostly) pass strict type checking, something which could have prevented this bug. Only this file has been changed. The only type errors in this file are in the safe_convert function and are due to problems in other files. To prevent further problems in the future, the project should work towards enabling strict type checking permanently after fixing the vast number of type problems.
dosubot
bot
added
size:L
github-actions
bot
added
bug
edwinjosechittilappilly
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Good work! Thanks for the PR
Can we handle this without changing the previous function names?
Cause we have a follow up PR from @lucaseduoli for formatting.
github-actions
bot
added
bug
|
@lucaseduoli we might need to update the templates after this PR! |
github-actions
bot
added
bug
github-actions
bot
added
bug
github-actions
bot
added
bug
|
Changes Made |
github-actions
bot
added
bug
github-actions
bot
added
bug
CodSpeed Performance ReportMerging #6747 will degrade performances by 27.6%Comparing Summary
Benchmarks breakdown
|
ogabrielluiz
added
lgtm
ogabrielluiz
changed the title
github-actions
bot
added
bug
github-actions
bot
added
bug
tianzhipeng-git
pushed a commit
to tianzhipeng-git/langflow
that referenced
this pull request
Feb 22, 2025
…angflow-ai#6747) * fix: updated ChatOutput component not working with streaming enabled (langflow-ai#6744) fixes: 69df913 Updated to handle the forgotten Generator case for self.input_value (encountered when streaming is enabled). Overhauled the chat.py under outputs to (mostly) pass strict type checking, something which could have prevented this bug. Only this file has been changed. The only type errors in this file are in the safe_convert function and are due to problems in other files. To prevent further problems in the future, the project should work towards enabling strict type checking permanently after fixing the vast number of type problems. * [autofix.ci] apply automated fixes * [autofix.ci] apply automated fixes (attempt 2/3) * update templates and make sure they support streaming without making breaking chnages * update templates * [autofix.ci] apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: Edwin Jose <edwin.jose@datastax.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: updated ChatOutput component not working with streaming enabled (#6744)
fixes: 69df913
Updated to handle the forgotten Generator case for self.input_value (encountered when streaming is enabled).
Overhauled the chat.py under outputs to (mostly) pass strict type checking, something which could have prevented this bug.
Only this file has been changed. The only type errors in this file are in the safe_convert function and are due to problems in other files.
To prevent further problems in the future, the project should work towards enabling strict type checking permanently after fixing the vast number of type problems.