Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: add tests for build docker image when dockerfile changed #10732

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Nov 15, 2024

Summary

  • add CI test job for building docker images for API and web module, only triggered when the dockerfile changed
  • to ensure the required os and packages (eg. native packages and building environment on os) are installable and ready to build, in particular, aligning with the correct pinned version code and combination for chip platforms.
  • build docker images for multi platforms of linux/amd64 and linux/arm64
  • the built images will NOT be pushed to Docker Hub
  • the docker build summary will be appended to the CI job's summary

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@bowenliang123 bowenliang123 marked this pull request as ready for review December 16, 2024 13:58
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 16, 2024
@bowenliang123 bowenliang123 force-pushed the docker-build-test branch 2 times, most recently from 309cce9 to 50ea4cb Compare December 20, 2024 13:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant