Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: comfyui tool supports https #11823

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

shaxiaozz
Copy link
Contributor

According to the comfyui address entered by the user, if it is http, the websocket is ws, if it is https, the websocket is wss

fix #11822

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 19, 2024
@crazywoola
Copy link
Member

Please do not modify the PR template and fill in the required contents.

@crazywoola crazywoola added the 🔨 feat:tools Tools for agent, function call related stuff. label Dec 19, 2024
@shaxiaozz
Copy link
Contributor Author

@crazywoola Thanks for the reminder. Here is the content

Summary

Fixes #11822
Because not all comfyui are deployed with dify, this part of the code currently has a check for "if comfyui is an https website, it cannot be successfully connected", so the judgment of the http protocol is added. If the comfyui website protocol is http, the websocket connection string is ws://, if the comfyui website protocol is https, then the websocket connection string is wss://.

Tip

Fixes #11822

Screenshots

Before:
This is an error before it is fixed. Regardless of the comfyui website protocol, ws:// will be used for websocket connectivity testing.
image

After:
This is after the repair, select the websocket connection string according to the comfyui website protocol
image

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 19, 2024
@crazywoola crazywoola merged commit 1548501 into langgenius:main Dec 19, 2024
5 checks passed
@charli117
Copy link
Contributor

@shaxiaozz Hi, You have missed, in comfyui_client.py open_websocket_connection also need to synchronize the adjustment, the current adjustment can only ensure that the verification is successful, but the graph generation still fails.

image

For example:
image

@shaxiaozz
Copy link
Contributor Author

@charli117 OMG, sorry. Didn't see this part of the code.

jiangbo721 pushed a commit to jiangbo721/dify that referenced this pull request Dec 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐞 bug Something isn't working 🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Comfyui tool cannot support HTTPS(WSS)
3 participants