Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: change CredentialsValidateFailedError to inherit from ValueError #11950

Conversation

laipz8200
Copy link
Member

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 21, 2024
@laipz8200 laipz8200 requested a review from crazywoola December 21, 2024 17:49
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 22, 2024
@crazywoola crazywoola merged commit 10caab1 into main Dec 22, 2024
8 checks passed
@crazywoola crazywoola deleted the fix/change-CredentialsValidateFailedError-to-inherit-from-ValueError branch December 22, 2024 02:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants