Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: improve error handling for file retrieval in AwsS3Storage #12002

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: improve error handling for file retrieval in AwsS3Storage #12002

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b340ba
fix: improve error handling for file retrieval in AwsS3Storage
laipz8200 Dec 23, 2024
22ec8af
chore: code format
laipz8200 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion api/extensions/storage/aws_s3_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ def load_stream(self, filename: str) -> Generator:
yield from response["Body"].iter_chunks()
except ClientError as ex:
if ex.response["Error"]["Code"] == "NoSuchKey":
raise FileNotFoundError("File not found")
raise FileNotFoundError("file not found")
elif "reached max retries" in str(ex):
raise ValueError("please do not request the same file too frequently")
else:
raise

Expand Down
Loading