fix: treat temporary failures as activity #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
=======================================
Coverage 95.79% 95.79%
=======================================
Files 20 20
Lines 1331 1331
Branches 115 115
=======================================
Hits 1275 1275
Misses 46 46
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
languitar
force-pushed
the
feature/erros-as-activity
branch
from
3cec889 to
59e2d54
Compare
When an activity check fails with a TemporaryCheckError, we now treat that situation as activity to prevent unintentional shutdowns of the system due to having a check configured wrongly or simply because of a temporary name resolution error or alike. Fixes: #589
languitar
force-pushed
the
feature/erros-as-activity
branch
from
59e2d54 to
8c96853
Compare
|
🎉 This PR is included in version 7.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an activity check fails with a TemporaryCheckError, we now treat that situation as activity to prevent unintentional shutdowns of the system due to having a check configured wrongly or simply because of a temporary name resolution error or alike.
Fixes: #589