feat: support newFactory method when resolving factory #1922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebdw
force-pushed
the
newFactory
branch
2 times, most recently
from
1a69a1d
to
0c203c1
Compare
2 tasks
canvural
force-pushed
the
2.x
branch
3 times, most recently
from
39d60e2
to
c4d0ee6
Compare
|
Thank you! |
canvural
pushed a commit
that referenced
this pull request
Nov 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1810
Changes
Hello!
This PR adds support for the
newFactorymethod which can point to a model that's outside the typical convention.Thanks!