Add GitHub actions #103

alexsoft · 2021-01-03T23:01:01Z

I guess actions themselves should be enabled in this repository, but I prepared two workflows:

run tests on different versions of php and with different flags (prefer-lowest and prefer-stable)
run tests on php 7.4 with coverage, as there is no need to execute coverage parts on all versions of php

irazasyed · 2021-01-05T02:25:43Z

Thanks for the PR. This was a much needed one. Appreciate it. 👍

Could you also please add PHP 8 support?

alexsoft · 2021-01-05T12:10:27Z

@irazasyed, sure.
Which version should be used for coverage workflow then? 7.4 or 8.0?

…nning tests with coverage

irazasyed · 2021-01-05T16:58:07Z

8.0 is good.

alexsoft · 2021-01-05T17:01:15Z

@irazasyed done. I also took the liberty to allow phpunit 9 :)

irazasyed · 2021-01-05T17:02:29Z

I noticed that. Good, appreciated :)

Thanks!

alexsoft · 2021-01-05T17:06:45Z

@irazasyed There is still something wrong with scrutinizer, but I am not absolutely sure how to fix it

alexsoft marked this pull request as ready for review January 3, 2021 23:01

alexsoft force-pushed the github-actions branch 3 times, most recently from b682b2a to 548e66e Compare January 3, 2021 23:10

alexsoft force-pushed the github-actions branch from 548e66e to 52fb68a Compare January 5, 2021 16:52

Added two github actions workflows: for running only tests and for ru…

7baf0e7

…nning tests with coverage

alexsoft force-pushed the github-actions branch from 52fb68a to 7baf0e7 Compare January 5, 2021 16:56

irazasyed merged commit 66c834e into laravel-notification-channels:master Jan 5, 2021

Provide feedback