Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Added 8.1 as experimental for tests, dropped 7.1 #118

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Added 8.1 as experimental for tests, dropped 7.1 #118

merged 2 commits into from
Oct 6, 2021

Conversation

alexsoft
Copy link
Member

@alexsoft alexsoft commented Oct 5, 2021

  1. Based on this page https://packagist.org/packages/laravel-notification-channels/telegram/php-stats, 7.1 is almost not used, so I think it can be dropped, so I've updated composer.json and tests workflow
  2. Changed coverage workflow to run on 7.4, as scrutinizer ocular script cannot work on 8.0 for now

@alexsoft alexsoft changed the title Experimental 8.1 drop 7.1 Added 8.1 as experimental for tests, dropped 7.1 Oct 5, 2021
@irazasyed irazasyed merged commit c489bb8 into laravel-notification-channels:master Oct 6, 2021
@irazasyed
Copy link
Member

Thank you 👍

@alexsoft
Copy link
Member Author

alexsoft commented Oct 6, 2021

@irazasyed thank you for merging. Do you think this PR could qualify for hacktoberfest? if yes, please add hacktoberfest-accepted label

@irazasyed
Copy link
Member

Done ✅

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexsoft @irazasyed