Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[9.x] Specify exception throwing for Filesystem in upgrade guide #7755

Merged
merged 2 commits into from
Feb 28, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Feb 28, 2022

It seems this was forgotten from laravel/framework#33612. Flysystem no longer throws a specific FileExistsException exception which makes it unclear why a file couldn't be written. Therefor we decided to catch all internal exception throwing by Flysystem and return false when a write operation fails. This also adheres more to the method signature of the FilesystemAdapter which only allowed a boolean to be returned.

See laravel/framework#41269

@taylorotwell taylorotwell merged commit 410a8bf into 9.x Feb 28, 2022
@taylorotwell taylorotwell deleted the driesvints-patch-1 branch February 28, 2022 16:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants