Str::trim changed Behavior

[mathiasgrimmcycle]

Laravel Version

11.22.0

PHP Version

8.3.10

Database Driver & Version

No response

Description

Previously, on Laravel 10, the str()->trim()->toString() worked differently.

Steps To Reproduce

$value = " " . chr(0) . " ";

dd(
    "version: " . app()->version(),

    "using str::trim: " .
        str($value)
            ->trim()
            ->toString(),

    "using trim: " . trim($value),

    "using preg_replace: " .
        preg_replace(
            '~^[\s\x{FEFF}\x{200B}\x{200E}]+|[\s\x{FEFF}\x{200B}\x{200E}]+$~u',
            "",
            $value
        ),

    "FIXED preg_replace: " .
        preg_replace(
            '~^[\s\x{FEFF}\x{200B}\x{200E}]+|[\s\x{FEFF}\x{200B}\x{200E}\x00]+$~u',
            "",
            $value
        ),

    // Laravel 10: true
    str($value)
        ->trim()
        ->toString() === trim($value),

    // Laravel 11: false
    str($value)
        ->trim()
        ->toString() === trim($value)
);

Output Laravel 10

"version: 10.48.17"
"using str::trim: "
"using trim: "
"using preg_replace: \x00"
"FIXED preg_replace: "
true
true

Output Laravel 11

"version: 11.22.0"
"using str::trim: \x00"
"using trim: "
"using preg_replace: \x00"
"FIXED preg_replace: "
false
false

We could either use this regex addition \x00 or do something like

// added trim here
preg_replace('~^[\s\x{FEFF}\x{200B}\x{200E}]+|[\s\x{FEFF}\x{200B}\x{200E}]+$~u', '', trim($value))```

[driesvints]

Hmm unsure what caused this. Could you propose your change backed with some tests?

[mathiasgrimmcycle]

Sure, brb

[mathiasgrimmcycle]

I've Already found the issue.
The str() previously used the Stringable class which internally used the PHP build-in trim while the new implementation of Stringable uses Str::trim() which only uses the PHP trim when the regex fails.

Pushing a PR in a few

[mathiasgrimmcycle]

There you go: https://github.com/laravel/framework/pull/52684/files

Please let me know if yo need me to change anything