[5.1] Use laravel's log writer class instead of monolog. #10922
Merged
+0
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Laravel's cool Illuminate\Log\Writer already implements the
Psr\Log\LoggerInterface
interface. Using the Monolog logger for thePsr\Log\LoggerInterface
binding bypasses the Logging event system of the laravel. For instance, I just wanted to log all the exceptions to theconsole
for the quick view 👓 :And found out that the events were not firing, because the
Monolog\Logger
was being injected for thePsr\Log\LoggerInterface
.I hope it all make sense :)
Usman.