[8.x] Split Collections Into A Separate Package #32478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
Yesssssssssss I am so happy! |
|
YYOOOOOUUUUHHOOOUUU! 🎉 thx @regiszanandrea for the ping! (After several years trying to push that, it only needed one tweet to @driesvints to got it! 🤣) |
nunomaduro
approved these changes
Apr 21, 2020
|
Nice |
|
Is the plan to remove the extended classes in the future? So there is no duplicate Collection and Macroable classes? |
|
@olivernybroe while technically yes I think it could be a year or two (or more) away. There is no maintenance overhead for us keeping them and it only inflicts pain on users by removing them. |
X-Coder264
reviewed
Apr 21, 2020
|
Nice! Any chance that pagination could be added in now? A lot of love for this out there still: https://gist.github.com/simonhamp/549e8821946e2c40a617c85d2cf5af5e |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits collections into a separate package while remaining backward compatible with older releases of Laravel.
This also necessitated the creation of a new
illuminate/macroablepackage.The
Illuminate\Supportcollection classes were left in place and simply extend the newIlluminate\Collectionsclasses where appropriate and override a few construction methods that use theselfkeyword. TheIlluminate\Support\Arrclass was treated the same way.No existing tests needed to be changed.