[8.x] Avoid SwiftMailer forceReconnection when not running from a queue daemon #36709
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that emails that are sent in bulk all use separate connections (even though they are not simultaneous, there can be a limit of connections per minute per IP set for an SMTP server). As I've found in multiple pull requests (i.e., #4573), there has been a problem with long lasting SMTP connections due to some problems with SwiftMailer and a simple solution for it:
However, these problems are only encountered when a program is executed from a queue daemon (
php artisan queue:work
orphp artisan queue:listen
), so there can be a compromise between dealing with the SSL broken pipe error and sending multiple emails.I propose setting a flag (or checking somehow else, if there's a better way for it) for when the script is executed from a queue daemon, then, when an email is sent via SMTP and the flag is not present, the SMTP connection will no longer be stopped. This would help in CRON jobs or in case of synchronous mail sending and wouldn't ruin queues a second time.