Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[9.x] Adds the scoped method to the container contract #37679

Merged
merged 2 commits into from
Jun 14, 2021
Merged

[9.x] Adds the scoped method to the container contract #37679

merged 2 commits into from
Jun 14, 2021
+18 −0

Conversation

tonysm
Copy link
Contributor

@tonysm tonysm commented Jun 13, 2021

Added

  • Adds the scoped method to the container contract

The method was added to Laravel 8 (here), but I guess this is a breaking change for the contract? Not sure.

@tonysm
Adds the scoped to the container contract

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 620DB20B566E2267
Learn about vigilant mode
2c91f6f
@igorgaming
Copy link

igorgaming commented Jun 13, 2021 •
edited
Loading

Yes, its breaking changes.
Also, you probably also need to add the public function scopedIf($abstract, $concrete = null) method: its here

@tonysm
Add the scopedIf method to the container contract

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e133ac0
@taylorotwell taylorotwell merged commit 075b6b2 into laravel:master Jun 14, 2021
@BrandonSurowiec BrandonSurowiec mentioned this pull request Jun 28, 2021
Closed
This was referenced Jul 13, 2021
Merged
Merged
@felixdorn felixdorn mentioned this pull request Sep 19, 2021
Closed
@otilor otilor mentioned this pull request Jan 1, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tonysm @igorgaming @taylorotwell