Skip to content

[10.x] Fix flakey HttpClientTest test #48166

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2023
Merged

[10.x] Fix flakey HttpClientTest test #48166

merged 1 commit into from
Aug 25, 2023

Conversation

joshbonnick
Copy link
Contributor

Similar to #48156. This PR replaces the use of $startTime = microtime(true); with Sleep::fake().

The updated test in HttpClientTest was failing with the following:

Failed asserting that 0.33161306381225586 matches expected 0.3.

Expected: 0.3
Actual: 0.33161306381226

@taylorotwell taylorotwell merged commit 0a0c1de into laravel:10.x Aug 25, 2023
@joshbonnick joshbonnick deleted the patch-1 branch August 25, 2023 13:40
@edcheyjr edcheyjr mentioned this pull request Sep 4, 2023
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshbonnick @taylorotwell