[10.x] Give access to job UUID in the job queued event #48179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
commented
Aug 25, 2023
| * @return void | ||
| */ | ||
| protected function raiseJobQueuedEvent($jobId, $job) | ||
| protected function raiseJobQueuedEvent($jobId, $job, $payload) |
There was a problem hiding this comment.
This is technically a breaking change, however I'm not sure if we expect anyone to override it.
If we are concerned about this, we use magic and just access it via func_get_args() but not have it in the method signature. We have done this before in the framework.
driesvints
requested changes
Aug 25, 2023
Co-authored-by: Dries Vints <dries@vints.io>
Co-authored-by: Dries Vints <dries@vints.io>
|
Thanks, @driesvints |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JobQueuedevent is dispatched whenever a job has been pushed to the queue (although, not for "bulk" jobs).The
JobQueuedevent does expose the database's record ID, however this ID changes if a job fails and is retried.Currently the jobs "sticky" ID - which is held in the payload - is not available.
The job's payload ID is sticky because it does not change when a job fails and is retried - however the database ID does change.
This change makes tracking the job from queued through all it's lifecycle hooks much easier. Without it...it's pretty much impossible.