Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[10.x] Add serializeAndRestore() to NotificationFake #50935

Merged

Conversation

dbpolito
Copy link
Contributor

@dbpolito dbpolito commented Apr 5, 2024

Similar to what was added at #48131 , this PR introduces the same feature to NotificationFake...

Testing notification was sent is not enough if for some reason you're pushing it to the queue and it has problems serializing / unserializing... In my case, i was sending an Empty model...

@dbpolito
Copy link
Contributor Author

dbpolito commented Apr 5, 2024

FYI: the error on tests doesn't seem related to my PR as it's happening on 10.x branch

@taylorotwell taylorotwell merged commit 5d3fa1c into laravel:10.x Apr 7, 2024
13 of 24 checks passed
@dbpolito dbpolito deleted the notificationFake-serializeAndRestore branch April 7, 2024 18:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants