Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[10.x] Fix apa on non ASCII characters #51428

Merged
merged 5 commits into from
May 16, 2024

Conversation

faissaloux
Copy link
Contributor

@faissaloux faissaloux commented May 16, 2024

Helloo 👋

In this PR I have fixed the bug on Str::apa() that does not capitalise non ASCII characters.

Code

Str::apa('Être écrivain commence par être un lecteur.');
Str::apa("устное слово – не воробей. как только он вылетит, его не поймаешь.");

Expected

Être Écrivain Commence par Être un Lecteur.
Устное Слово – Не Воробей. Как Только Он Вылетит, Его Не Поймаешь.

Actual

être écrivain Commence Par être Un Lecteur.
устное слово – не воробей. как только он вылетит, его не поймаешь.

Fixes #51427

@driesvints driesvints changed the title Fix apa on accented words [10.x] Fix apa on accented words May 16, 2024
@driesvints
Copy link
Member

@faissaloux it's always better to write a description at what this fixes instead of linking to an issue so Taylor knows what this is about.

@faissaloux
Copy link
Contributor Author

@driesvints Updated.

Thanks!

@faissaloux faissaloux changed the title [10.x] Fix apa on accented words [10.x] Fix apa on non ASCII characters May 16, 2024
@taylorotwell taylorotwell merged commit 010b548 into laravel:10.x May 16, 2024
24 checks passed
@faissaloux faissaloux deleted the fix-apa-on-accented-words branch May 17, 2024 12:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants