Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[11.x] Fix double-quoted string literals on SQLite #51615

Conversation

hafezdivandari
Copy link
Contributor

Fixes #51609

As of SQLite 3.41.0 the double-quoted string literals misfeature is disabled by default for CLI builds.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@hafezdivandari hafezdivandari marked this pull request as ready for review May 29, 2024 12:09
@hafezdivandari hafezdivandari marked this pull request as draft May 29, 2024 13:55
@hafezdivandari hafezdivandari marked this pull request as ready for review May 29, 2024 14:10
@taylorotwell taylorotwell merged commit 956a63b into laravel:11.x May 29, 2024
28 checks passed
@hafezdivandari hafezdivandari deleted the 11.x-sqlite-double-quoted-string-literals branch May 29, 2024 18:47
GrahamCampbell pushed a commit to GrahamCampbell/framework that referenced this pull request Jul 21, 2024
taylorotwell pushed a commit that referenced this pull request Jul 22, 2024
Co-authored-by: Hafez Divandari <hafezdivandari@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQLiteGrammar.php compileColumns failing on quotes around table name
3 participants