Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[11.x] Enhance DB inspection commands #52501

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Aug 15, 2024

This PR enhances DB inspection commands:

  • On db:show command:
  • On db:table command:
    • Adds support for schema names (pgsql and sqlsrv), now lists full table names: schema.table.
    • Displays more table info when available: table's comment (pgsql and mysql), engine (mysql), and collation (mysql).
    • Displays column's generation type for generated columns, "stored" or "virtual" (all DBs)
    • Fixes zero table's size hadn't been displayed.

Copy link

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@hafezdivandari hafezdivandari changed the title [11.x] Fix db commands with non-default schema names [11.x] Enhance DB inspection commands Aug 15, 2024
@hafezdivandari hafezdivandari marked this pull request as ready for review August 15, 2024 18:34
@taylorotwell taylorotwell merged commit f0de069 into laravel:11.x Aug 15, 2024
29 checks passed
@hafezdivandari hafezdivandari deleted the 11.x-fix-db-commands branch August 15, 2024 18:42
@bjuppa
Copy link

bjuppa commented Aug 16, 2024

Very nice @hafezdivandari, thank you for this PR! It definitely solves the issues I described in #52496, and more!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artisan db:show and db:table fails when database has tables in multiple schemas
3 participants