-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[php84] Fix some deprecations and lower requirements #52636
Conversation
Starting Point: After this PR: (Not completely a fair comparison due to using lowest vs stable, but that is okay for me) |
Very nice. Thanks @Jubeki |
Btw, we can also bump these dependencies inside our own composer.json |
Yeah I know, I just wanted to find out the lower bounds for now, without needing to update all composer.json files. |
I send the PR to the php84 branch, or should it go directly to 11.x branch?Is there a StyleCI Rule to enforce explicit nullable types?
A Quick Look / search on https://docs.styleci.io/fixers resulted in nothing.
PHP-CS-Fixer has a rule for this (which is also enforced in Laravel Pint)
https://cs.symfony.com/doc/rules/function_notation/nullable_type_declaration_for_default_null_value.html
Lower Requirements for PHP 8.4:
^2.0.3
^1.6.10
^7.1.3
or^7.0.10
^2.0.1
for PHPUnit 10 and^3.0.1
for PHPunit 11^3.4.0
^6.0.1
I also adjusted the PHPunit requirements in Github Workflows accordingly for nullable types.