[11.x] Auto-register commands in routes/console.php
#52867
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on route registration in a Laravel app, I noticed some inconvenience when using the
using
callback of thewithRouting
method.In particular, the main issue was that commands defined in
routes/console.php
were not registered anymore. When checking the docs, I saw that there is a way to register commands using thewithCommands
method.However, to achieve the same behaviour of the
withRouting
method you must pass theroutes/console.php
file as a parameter.I think the DX could be improved by checking if the
routes/console.php
file exists and if so, registering all commands (including their schedule) automatically. This should be a good sensible default since theroutes/console.php
file is the default way to register commands in Laravel 11.So before:
and after:
I couldn't find any existing tests for the
ApplicationBuilder
so I decided to also not add any in this PR.