Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[11.x] add Generics to Paginator's ArrayAccess methods #54428

Merged

Conversation

taka-oyama
Copy link
Contributor

This PR will make Paginator aligned with Collection, which already has these generic types defined for ArrayAccess methods.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@taylorotwell taylorotwell reopened this Jan 31, 2025
@taylorotwell taylorotwell merged commit fcd058f into laravel:11.x Jan 31, 2025
77 checks passed
@taka-oyama taka-oyama deleted the feature/add-generics-paginator-access branch January 31, 2025 08:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants