Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[11.x] fix 'parsePipeString' in pipeline helper #54643

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

igzard
Copy link
Contributor

@igzard igzard commented Feb 16, 2025

Fix: Ensure parsePipeString() Returns an Empty Array Instead of an Empty String

Return Value of parsePipeString():

If the character is not present in the $pipe variable, explode(':', $pipe, 2) returns an array with a single element: [$pipe].
While array_pad() extends the array, the second value will be an empty string ('') instead of an empty array ([]).
This causes an issue when calling explode(',', $parameters), as explode(',', '') returns [''], not [].

@taylorotwell taylorotwell merged commit 1e2232f into laravel:11.x Feb 17, 2025
44 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants