[11.x] Fix routeCollection get method return value when searching by dot not… #54672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Arr::get($this->routes, $method, [])
from the get method in\Illuminate\Routing\RouteCollection::get
because it allows to return aroute
object when searching with "dot" notation. despite the method name, parameter, and PHPDoc indicating that the search is performed by$method
(e.g GET , POST ...) and should return array of Route objects when foundChanges
as described and discussed in #54541
get
method in\Illuminate\Routing\RouteCollection::get
has a side effect that allows us to search by "dot" notationexample:
$this->routeCollectionget->('GET.foo/index');
will return an object instance ofRoute
(not array)which contradict:
Solution
Arr::get()
and use null-coalescing operator instead to perform a search on the routes collection (first level that contains the methods)