Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Revert "Fix Collection::implode with \Stringable objects" #54691

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Revert "Fix Collection::implode with \Stringable objects" #54691

merged 1 commit into from
Feb 19, 2025

Conversation

crynobone
Copy link
Member

Reverts #54630

@crynobone
Copy link
Member Author

fixes #54689

@crynobone crynobone added the bug label Feb 19, 2025
@nuernbergerA
Copy link
Contributor

i can confirm this fixes the BC
@crynobone i can open a new PR to ensure implode works as it should

@crynobone
Copy link
Member Author

@nuernbergerA I believe you should be able to pass the condition for a collection of ArrayAccess instead of checking for Stringable.

It might be best to target 12.x instead.

@nuernbergerA
Copy link
Contributor

@crynobone i think you misunderstood me

here is the missing test
#54704

@nuernbergerA nuernbergerA mentioned this pull request Feb 19, 2025
Merged
@taylorotwell taylorotwell merged commit ca54da6 into 11.x Feb 19, 2025
47 checks passed
@taylorotwell taylorotwell deleted the revert-54630-bugfix/collection-implode-stringable branch February 19, 2025 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crynobone @nuernbergerA @taylorotwell