Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix translation key for "Regards" in email view #54713

Closed
wants to merge 1 commit into from

Conversation

mforstme
Copy link

This pull request includes a small change to the src/Illuminate/Notifications/resources/views/email.blade.php file. The change modifies the salutation format in the email template.

  • Changed the salutation from @lang('Regards,')<br> to @lang('Regards'),<br>.

@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

@mforstme
Copy link
Author

The checks all run through and the fix is so trivial and clear that the commentary could not be more explicit.

@mforstme mforstme deleted the patch-2 branch February 21, 2025 10:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants