[5.0] STMP restart for Swift_Mailer #8222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YOzaz
changed the title
This was referenced Mar 30, 2015
| { | ||
| $transport = $this->getSwiftMailerTransport(); | ||
|
|
||
| if ( ! isset($transport)) |
There was a problem hiding this comment.
One line this please. Also, isset is wrong here.
|
I don't want to force this on everyone. Not sure if it will break some existing applications using SMTP. |
|
Can we at least document this somewhere? It would save a lot of people time researching this only to see that Laravel does not retry the connection if your in the daemon queue (knowing that it makes sense) but seems to be a frequent occurrence. |
|
@lukepolo suppose you can make a pull request for docs here: https://github.com/laravel/docs/blob/5.2/queues.md#coding-considerations-for-daemon-queue-listeners |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second try.