Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[1.x] Lock inertiajs/inertia-laravel to ^0.2.4 #371

Merged
merged 1 commit into from
Oct 21, 2020
Merged

[1.x] Lock inertiajs/inertia-laravel to ^0.2.4 #371

merged 1 commit into from
Oct 21, 2020

Conversation

claudiodekker
Copy link
Contributor

@claudiodekker claudiodekker commented Oct 21, 2020

This prevents issues with PUT/POST/PATCH requests due to the Middleware changes introduced in inertiajs/inertia-laravel ^0.3. This is not an issue on master, because on that version these changes are already implemented (#327)

See https://twitter.com/don_jon243/status/1318926992645959683 for more info

@claudiodekker claudiodekker changed the title Lock inertiajs/inertia-laravel to ^0.2.4 [1.x] Lock inertiajs/inertia-laravel to ^0.2.4 Oct 21, 2020
@reinink
Copy link
Contributor

reinink commented Oct 21, 2020

Good catch @claudiodekker. 👍

@taylorotwell taylorotwell merged commit 5a1967b into laravel:1.x Oct 21, 2020
@claudiodekker claudiodekker deleted the patch-1 branch October 21, 2020 17:03
taylorotwell added a commit that referenced this pull request Oct 22, 2020
* Lock inertiajs/inertia-laravel to ^0.2.4 (#371)

* Prevent body from scrolling when modal is open

* Replace flex-centering with mx-auto

* Make Modal scrollable

* inset-0, overflow-y-auto - scroll the modal
* py-6 - add bottom padding for the modal parent

* Fix for FF

Replace parent `padding-bottom` to child `margin-bottom` as described here https://stackoverflow.com/a/38177668/3071884

* Inertia: Replace flex-centering with mx-auto

* Inertia: Make Modal scrollable

* Inertia: Fix for FF

* Update InstallCommand.php

Co-authored-by: Claudio Dekker <1752195+claudiodekker@users.noreply.github.com>
Co-authored-by: Taylor Otwell <taylor@laravel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants