Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[1.x] Use Alpine directly for guest layout #485

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Nov 24, 2020

This reverts a small part of #450. What happened was that because the guest layout isn't an SPA in Inertia the console starts to throw errors because it cannot resolve routes. This is technically solved in Jetstream v2 where the guest layout isn't copied anymore and all views are Inertia scripts. But for Jetstream 1.x we'll need to reference Alpine directly instead of loading in the entire app.js on the guest layout.

I have to note that nothing was actually broken, just the console which was showing the errors from the screenshots in the issue below.

Fixes #482

Verified

This commit was signed with the committer’s verified signature.
driesvints Dries Vints
@driesvints
Copy link
Member Author

Also, afaik the guest views don't use Alpine so not sure if it's needed at all?

@taylorotwell taylorotwell merged commit b9b540e into 1.x Nov 24, 2020
@taylorotwell taylorotwell deleted the fix-guest-layout-inertia branch November 24, 2020 14:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught ReferenceError: route is not defined
2 participants