Skip to content

Add --local-composer flag to the install command #588

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from
Closed

Add --local-composer flag to the install command #588

wants to merge 2 commits into from

Conversation

miclaus
Copy link
Contributor

@miclaus miclaus commented Jan 5, 2021

Using this flag will use the local composer.phar binary installed at the base path instead of the global composer binary command.

This is useful for systems where composer is not installed globally.

Flag Usage:

php artisan jetstream:install livewire --local-composer

php artisan jetstream:install livewire --teams --local-composer

Executes e.g. php composer.phar require livewire/livewire:^2.0 laravel/sanctum:^2.6
instead of composer require livewire/livewire:^2.0 laravel/sanctum:^2.6

Not sure about the command flag description though.
Happy for suggestions.

Using this flag will use the local composer.phar binary installed at the base path instead of the global composer binary command.

This is useful for systems where composer is not installed globally.
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@miclaus
Copy link
Contributor Author

miclaus commented Jan 5, 2021

@taylorotwell The proposed flag is not necessary to be merged for the jetstream:install command.

However, developers using a local composer.phar binary instead of a globally installed composer binary cannot currently run the jetsteam:install command successfully, without a globally installed composer binary.

It would be best if the install command detects automatically whether to use the globally installed composer binary or (if available) a local composer.phar binary to require packages.

Thanks for your time.

@driesvints
Copy link
Member

@miclaus when I said we could consider this I meant that an argument could be added to inculde the full pathname to the composer binary, not just a flag that assumes a phar. If you want to retry this please try with that in mind.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants