Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add z-index to the modal #633

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Add z-index to the modal #633

merged 1 commit into from
Jan 14, 2021

Conversation

ahmadmayahi
Copy link
Contributor

Add z-index to the modal so it doesn't overlap with other elements.

@taylorotwell
Copy link
Member

Example of how it is broken now?

@ahmadmayahi
Copy link
Contributor Author

@taylorotwell

Please see this:

https://i.imgur.com/S5uX8UE.png

@driesvints
Copy link
Member

Which browser is that?

@ahmadmayahi
Copy link
Contributor Author

@driesvints

  • Device: iPhone XS
  • Browser: Safari
  • iOS version: 14.3

@driesvints
Copy link
Member

driesvints commented Jan 14, 2021 •
edited
Loading

Seems to work fine for me on my iPhone 11 Pro Max with the same safari specs:

IMG_0761 (1)

@taylorotwell taylorotwell merged commit ceeb6a6 into laravel:2.x Jan 14, 2021
@taylorotwell
Copy link
Member

I see we do have it on the Livewire version so will go ahead and merge.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmadmayahi @taylorotwell @driesvints