-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[13.x] Fix register a custom rendering closure for OAuthServerException
#1763
Merged
taylorotwell
merged 14 commits into
laravel:13.x
from
hafezdivandari:12.x-fix-rendering-oauth-server-exception
Jul 2, 2024
Merged
[13.x] Fix register a custom rendering closure for OAuthServerException
#1763
taylorotwell
merged 14 commits into
laravel:13.x
from
hafezdivandari:12.x-fix-rendering-oauth-server-exception
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2024
OAuthServerException
OAuthServerException
…ithub.com/hafezdivandari/passport into 12.x-fix-rendering-oauth-server-exception
Thanks @hafezdivandari |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR laravel/framework#51968 has to be merged before this.
Fixes #1756
Overriding the
render
method on\Laravel\Passport\Exceptions\OAuthServerException
causes issue when registering a custom rendering closure, because this method takes precedence over the registered custom closure.