Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[13.x] Fix register a custom rendering closure for OAuthServerException #1763

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Jun 30, 2024

PR laravel/framework#51968 has to be merged before this.

Fixes #1756

Overriding the render method on \Laravel\Passport\Exceptions\OAuthServerException causes issue when registering a custom rendering closure, because this method takes precedence over the registered custom closure.

@hafezdivandari hafezdivandari marked this pull request as draft June 30, 2024 04:31
@hafezdivandari hafezdivandari changed the base branch from 12.x to 13.x July 2, 2024 04:47
@hafezdivandari hafezdivandari changed the title [12.x] Fix register a custom rendering closure for OAuthServerException [13.x] Fix register a custom rendering closure for OAuthServerException Jul 2, 2024
@hafezdivandari hafezdivandari marked this pull request as ready for review July 2, 2024 20:23
@taylorotwell taylorotwell merged commit b2bb7df into laravel:13.x Jul 2, 2024
7 checks passed
@hafezdivandari hafezdivandari deleted the 12.x-fix-rendering-oauth-server-exception branch July 2, 2024 20:59
@driesvints
Copy link
Member

Thanks @hafezdivandari

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Custom Handle Laravel\Passport\Exceptions\OAuthServerException in Laravel 11
3 participants