Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[1.x] Fix: Keep select fields open #441

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

angelej
Copy link
Contributor

@angelej angelej commented Feb 5, 2025

Many pulse cards use the <x-pulse::select /> component to sort or filter the results.
If the select component doesn't have an id attribute, it generates a random one on every rendering.
Because the id changes on every poll request (every 5 seconds), the DOM <select /> element gets replaced and automatically closes the input field.
Passing a static id to every <x-pulse::select /> component prevents DOM manipulations and keeps an active select field open.

image

@taylorotwell taylorotwell merged commit d360290 into laravel:1.x Feb 6, 2025
17 of 24 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants