Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[1.x] Fixes install command for applications migrated from 10.x to 11.x #84

Merged
merged 2 commits into from
Mar 14, 2024
Merged

[1.x] Fixes install command for applications migrated from 10.x to 11.x #84

merged 2 commits into from
Mar 14, 2024

Conversation

joedixon
Copy link
Collaborator

This PR updates the install process to:

  • Always attempt to enable the BroadcastServiceProvider in app.php
  • Always attempt to add Reverb's configuration options to broadcasting.php.

Resolves #79

@joedixon joedixon marked this pull request as draft March 14, 2024 11:09
@joedixon joedixon mentioned this pull request Mar 14, 2024
Merged
@driesvints driesvints marked this pull request as ready for review March 14, 2024 14:19
@driesvints driesvints requested a review from taylorotwell March 14, 2024 14:19
@taylorotwell taylorotwell merged commit d01860c into main Mar 14, 2024
11 checks passed
@taylorotwell taylorotwell deleted the fix/reverb-install branch March 14, 2024 14:20
@fylzero fylzero mentioned this pull request Mar 14, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: broadcasting.php required modifications
2 participants
@joedixon @taylorotwell