Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[5.x] Added 2 additional tests for GitHub driver programmatic scope merging and overwriting #729

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

TheAladeen
Copy link
Contributor

Hi All,

Sorry for a separate PR, forgot to add two tests to ensure changes do not break the existing documented methods of merging and overwriting scopes.

… and overwriting

Introduced tests to verify correct behavior when merging scopes from config with programmatic scopes using `scopes()` and overwriting them using `setScopes()`. These ensure the driver handles scope configurations as expected.
@taylorotwell taylorotwell merged commit 77be8be into laravel:5.x Jan 17, 2025
25 checks passed
@TheAladeen TheAladeen deleted the 5.x_Add_additional_scope_tests branch January 17, 2025 16:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants