Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

SSL setup? #27

Closed
larshp opened this issue Sep 5, 2016 · 9 comments
Closed

SSL setup? #27

larshp opened this issue Sep 5, 2016 · 9 comments

Comments

@larshp
Copy link
Owner

larshp commented Sep 5, 2016

see abapGit/abapGit#306

@nununo

@larshp
Copy link
Owner Author

larshp commented Sep 5, 2016

@nununo do you get the invalid certificate error when accessing the .git URL via browser? What is the error message in abapGit?

what kind of login method is used when accessing the web part?

try checking some of the following settings:
https://scn.sap.com/thread/3166828
https://scn.sap.com/thread/3492784
https://scn.sap.com/thread/3379951

perhaps try adding ?sap-system-login-basic_auth=X to the .git clone URL

also try modifying the url in https://github.com/larshp/abapGit/wiki/ZABAPGIT_TEST_SSL to see if it works, it might be easier to debug

@nununo
Copy link
Contributor

nununo commented Sep 6, 2016

We're using single sign-on so I assumed it would be automatic.
I'm not very familiar with web services in SAP so here's a screenshot of the logon data:
image

After some I added the client/user/pass logon data and then removed somehow the url is now HTTP instead of HTTPS and the port is different. So I now have a normal HTTP url for the .git file.

When I try to access it through the browser it is automatically downloaded as a file with 318 bytes with binary content.

But when I try to clone the repository, after some debugging I found that the URL get's a temporary redirect into the Single Sign-On system, the original URL is replaced by the new SSO url and... that's it: HTTP Communication Failure.

I'm now trying to understand how I can configure the SICF service in order to bypass the SSO... but I still didn't figured it out.

I'll keep trying... and will try to get someone BASIS to help me.

At least now the problem is identified and it doesn't seem to be a problem with abapGitServer ;) Unless you think it should be able to cope with this SSO issue.

Cheers,
Nuno

@nununo
Copy link
Contributor

nununo commented Sep 6, 2016

Solved. Everything is working now. I configured it in a way that the SSO is no longer in the middle.
Thanks for all the help! This problem was unrelated to SSL after all. Sorry for the confusion.

@larshp
Copy link
Owner Author

larshp commented Sep 6, 2016

was it a setting in SICF for ZGIT? can you add a few notes on how to fix it if somebody else experiences the same issue in the future?

@nununo
Copy link
Contributor

nununo commented Sep 6, 2016

Sure! What I did was:

  • Set the procedure from "Standard" to "Require Logon Data"
  • Fill in the Client, User and Password

And that was enough to make it work! I hope this helps others!

It hadn't tried it before because I was misled to think that the issue was related to SSL.

Question: why did you call the service ZGIT instead of ZABAPGITSERVER? It would have been more coherent with the project naming.

@larshp
Copy link
Owner Author

larshp commented Sep 6, 2016

just to have a shorter URL, my guess is it wont conflict with anything else, we can change it if you like

@nununo
Copy link
Contributor

nununo commented Sep 6, 2016

I think name coherence is very important in any project. If someone finds this service called ZGIT it will not be obvious if it is related to abapGit or abapGitServer. It's ambiguous. I'd give it a more explicit name like ZABAPGITSERVER. If this is possible of course, otherwise... not a big deal ;)

@larshp
Copy link
Owner Author

larshp commented Sep 6, 2016

good idea

larshp added a commit that referenced this issue Sep 9, 2016
larshp added a commit that referenced this issue Sep 9, 2016
@larshp
Copy link
Owner Author

larshp commented Sep 9, 2016

fixed, SICF service renamed from ZGIT to ZABAPGITSERVER, note that ZGIT service has to be deleted manually after pulling

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants