Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only insert completions if cursor is at EOL #20

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

9999years
Copy link
Contributor

If the pisces_only_insert_at_eol variable is set, closing-delimiters will be inserted / skipped past only while the cursor is at the end of the line.

This helps when modifying a command like

ls some directory

to quote an argument:

ls "some directory"

With Pisces' default configuration, you'll get:

ls ""some directory""

Closes issue #19.

Rebecca Turner added 2 commits August 3, 2019 15:42
If the `pisces_only_insert_at_eol` variable is set, closing-delimiters
will be inserted / skipped past only while the cursor is at the end of
the line.

This helps when modifying a command like

    ls some directory

to quote an argument:

    ls "some directory"

With Pisces' default configuration, you'll get:

    ls ""some directory""

Closes issue laughedelic#19.
- Use $text instead of $right in _pisces_insert_identical
    - Silly copy/paste error...
- Prefer `2>/dev/null` to deprecated `^/dev/null`
    - Pour one out for the ^ operator :(
- Prefer `test` to `[`
@laughedelic
Copy link
Owner

Hi @9999years! Thanks for the contribution and sorry that it took me so long to review. This is a very good addition and I think I'll turn this flag on for myself 😉

@laughedelic laughedelic merged commit 34971b9 into laughedelic:master Jul 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants