Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Inaccessible Backward Navigation in Note List Using Shift+Tab #11443

Closed
RafaelFernandesBR opened this issue Nov 26, 2024 · 1 comment · Fixed by #11446
Closed

Inaccessible Backward Navigation in Note List Using Shift+Tab #11443

RafaelFernandesBR opened this issue Nov 26, 2024 · 1 comment · Fixed by #11446
Labels
accessibility Related to accessibility bug It's a bug high High priority issues

Comments

@RafaelFernandesBR
Copy link

Operating system

Windows

Joplin version

3.1.24

Desktop version info

Joplin 3.1.24 (prod, win32)

ID do cliente: ecdb6b3128d549d29e46c9f0743a3b09
Versão Sync: 3
Versão do Perfil: 47
Keychain Suportada: Sim

Revisão: d581264

Backup: 1.4.2
Describe image: 1.7.0

Current behaviour

When focusing on the list of notes, either using the Ctrl+Shift+L command or manually with a screen reader, it is not possible to return to the interface using Shift+Tab.

Steps to reproduce:

  1. Focus on the list of notes using the shortcut or manually.
  2. Press Shift+Tab to exit the note list and navigate to the "Reverse sort order" button.
  3. Observe that it is not possible to return to the interface from the list. Navigation is only possible by moving forward with the Tab key.

Expected behaviour

Make it possible to exit the notes list normally, without blocking the interface. Both forward and backward (tab and shift+tab).

Logs

No response

@RafaelFernandesBR RafaelFernandesBR added the bug It's a bug label Nov 26, 2024
@personalizedrefrigerator personalizedrefrigerator added high High priority issues accessibility Related to accessibility labels Nov 26, 2024
personalizedrefrigerator added a commit to personalizedrefrigerator/joplin that referenced this issue Nov 26, 2024
This commit removes an inaccessible shift-tab override that made it
difficult to focus the note list controls. Previously:
- If the notebook list was hidden, pressing shift-tab from the note list
  logged an error (and otherwise did nothing).
- If the notebook list was visible, shift-tab skipped the note list
  controls and jumped to the notebook list.

Note: Other shift-tab overrides still exist that should be
removed for WCAG compliance (e.g. shift-tab from the notebook list) see
the WCAG compliance issue for details.
@personalizedrefrigerator
Copy link
Collaborator

Thank you for reporting this!

I've opened a pull request that removes these focus overrides. Prior to the pull request:

  • shift-tab from the note list maps to jump to the notebook list (even if the notebook list was hidden).
  • tab from the notebook list maps to "jump to the note list" (even if the note list was hidden).

The linked pull request removes these mappings and replaces them with shift-enter and enter, respectively. Enter was selected in part because it's similar to the keybindings in Visual Studio Code — in that application, pressing enter moves focus from the folder list to the editor. However, VSCode doesn't seem to have an equivalent binding for shift-enter.

I'm not certain that enter and shift-enter are the best replacements for the old navigation behavior (or if a replacement is even necessary). Feedback on this would be welcome.

laurent22 pushed a commit that referenced this issue Nov 27, 2024
…n pressing tab/shift-tab on the note list (#11446)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accessibility Related to accessibility bug It's a bug high High priority issues
Projects
None yet
2 participants