Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mobile,Desktop: Upgrade CodeMirror packages #11221

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 16, 2024

Summary

This pull request upgrades most @codemirror/ packages. This is similar to #11034.

To prevent regressions caused by the last upgrade attempt, this pull request also disables CodeMirror's use of the EditContext API.

Testing plan

Android 13:

  1. Open a note in edit mode.
  2. Move the cursor to the end of the note.
  3. With the SwiftKey keyboard, swipe to type 2-3 words.
  4. Verify that the words are added to the editor.
  5. Tap on the cursor once and click "select all".
  6. Verify that all content in the editor is selected.

This commit upgrades most `@codemirror/` packages, like
laurent22#11034, but disables the
EditContext API (see laurent22#11170).
@laurent22 laurent22 merged commit d7f4f5f into laurent22:dev Oct 26, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants