Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Desktop: Accessibility: Add accessible label to the "remove from share" button #11233

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Desktop: Accessibility: Add accessible label to the "remove from share" button #11233

merged 3 commits into from
Oct 26, 2024

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 19, 2024 •
edited
Loading

Summary

This pull request adds a missing label to the "remove from share" button on the share screen.

Testing plan

Fedora 40 (Linux):

  1. Enable the Orca screen reader.
  2. Start Joplin and open the share dialog for an existing share.
  3. Move accessibility focus to the "remove" button for a share item.
  4. Verify that Orca reads "Remove [[email]] from share" (replacing [[email]] with an email).

@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms accessibility Related to accessibility labels Oct 19, 2024
@laurent22 laurent22 merged commit 6cbdde5 into laurent22:dev Oct 26, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@personalizedrefrigerator @laurent22