Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Desktop: Resolves #11314: Make js-draw a default plugin #11516

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

laurent22
Copy link
Owner

No description provided.

@laurent22
Copy link
Owner Author

laurent22 commented Dec 14, 2024

@personalizedrefrigerator, please let me know I missed something in the default plugin config. One thing we could maybe improve is to move the settings from pluginRepositories.json to desktopDefaultPluginsInfo.ts to simplify the process.

@laurent22 laurent22 changed the title Desktop: Make js-draw a default plugin Desktop: Resolves #11314: Make js-draw a default plugin Dec 14, 2024
@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Dec 15, 2024

@personalizedrefrigerator, please let me know I missed something in the default plugin config. One thing we could maybe improve is to move the settings from pluginRepositories.json to desktopDefaultPluginsInfo.ts to simplify the process.

This looks good to me! Indeed, combining pluginRepositories.json and desktopDefaultPluginsInfo.ts would simplify the process of adding a default plugin. This would also allow adding types to the information in pluginRepositories.json.

@laurent22 laurent22 marked this pull request as ready for review December 16, 2024 09:48
@laurent22 laurent22 merged commit 6dc1bc7 into dev Dec 17, 2024
13 checks passed
@laurent22 laurent22 deleted the js-draw-default branch December 17, 2024 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants