Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: issue with the picker not opening on ios with the new architecture #542

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

exlymex
Copy link

@exlymex exlymex commented Mar 15, 2024

On the new architecture the TextInput used to display the text was intercepting events. This seems to be caused by the view-flattening algorithm moving it out of the parent view which has pointerEvents="box-only" set.

The solution would be either to add pointerEvents="none" to the TextInput itself, as done in this PR, or to disable the view flattening for the parent view (by adding collapsable={false} prop to it), so the native view structure would match the react one.

@exlymex exlymex changed the title fix: fixed the problem with the picker not opening on ios with the new architecture fix: issue with the picker not opening on ios with the new architecture Mar 16, 2024
@lfkwtz
Copy link
Contributor

lfkwtz commented Apr 23, 2024

does this have any regressions on the previous architecture?

@THE-REK
Copy link

THE-REK commented Nov 7, 2024

When I do this I can click on the picker, but the modal that opens goes to the top of the screen and is not visible.

Copy link

@NoodleOfDeath NoodleOfDeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can we merge this ASAP?

@dakota-kallas
Copy link

Agreed, this fixes the breaking change with Expo SDK 52.

@exlymex
Copy link
Author

exlymex commented Jan 1, 2025

does this have any regressions on the previous architecture?

This fix should be enough to fix this problem. And after doing a regression, I didn't notice any new problems arise.

@NoodleOfDeath
Copy link

does this have any regressions on the previous architecture?

This fix should be enough to fix this problem. And after doing a regression, I didn't notice any new problems arise.

no new problems <<<< breaking changes IMPO (in my personal opinion) this needs to be expedited sooner than later

@lfkwtz
Copy link
Contributor

lfkwtz commented Jan 6, 2025

@exlymex can you fix the conflicts?

@blur94
Copy link

blur94 commented Jan 10, 2025

Please, can this PR be merged? This can help resolve this particular issue. Please fix the conflict @exlymex

@depsimon
Copy link

In the meantime you can now pass the props to the Picker: textInputProps={{ pointerEvents: "none" }}

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants