Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cherry-pick self hosted to master #45

Merged
merged 5 commits into from
Apr 19, 2022

Conversation

gyohuangxin
Copy link
Member

@gyohuangxin gyohuangxin commented Apr 15, 2022

Description

This PR fixes #44

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

hershd23 and others added 5 commits April 15, 2022 09:47
Changes made to configure the self-hosted-runner
	modified:   .github/workflows/configurable-benchmark-test.yaml
Signed-off-by: hershd23 <hershdhillon23@gmail.com>
The commit automates below steps:
1. Create a CNCF CIL machine and register it as a self-hosted runner
2. Run SMP benchmarks on the self-hosted runner
3. Stop and remove the CNCF CIL machine and self-hosted runner

Signed-off-by: Huang Xin <xin1.huang@intel.com>
Signed-off-by: Huang Xin <xin1.huang@intel.com>
Signed-off-by: Huang Xin <xin1.huang@intel.com>
@gyohuangxin
Copy link
Member Author

@leecalcote Can you merge this? And then two github secrets should be added to let it work.

image

  1. CNCF CIL Token
    We use CNCF projects api key to use CNCF CIL's apis in our jobs, so we should add a secret named "CNCF_CIL_TOKEN" contains the api key, copy from equinix console page:
    image

  2. Personal access token
    We use a github personal access token here to give jobs the access to delete github runners. So we should add a secret named "PAT" contains a personal access token which have the access to this repo. If we don't have a personal access token, we can create one: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

I haven't the permission to add above two secrets in this repo, so can you add them or give me a accessible role?

@gyohuangxin gyohuangxin marked this pull request as ready for review April 16, 2022 16:01
@warunicorn19 warunicorn19 requested a review from leecalcote April 16, 2022 16:18
@gyohuangxin
Copy link
Member Author

@leecalcote @hershd23 Can you review this and give some advice about above permission issue? Thanks.

@leecalcote
Copy link
Member

Oh, I missed this PR earlier. Yes, we do have a service/robot account (l5io) whose PAT is available in this repo as an org-wide secret: GH_ACCESS_TOKEN. Yes, let’s get your user’s privileges elevated so that you can add the CIF token, too, @gyohuangxin

@leecalcote leecalcote merged commit 9ff7cf1 into layer5io:master Apr 19, 2022
@leecalcote
Copy link
Member

This folder in the community drive has a GitHub Process doc, which will be helpful reference and to which the new CIF token can be noted - https://drive.google.com/drive/folders/1O7TPo1FYkEYcUhQPx6hAzxPho7pWgtIp

@gyohuangxin
Copy link
Member Author

@leecalcote Thanks for giving me the privileges and I can add "CNCF_CIL_TOKEN" in this repo. I raised a PR #46 to change PAT name used in scripts to "GH_ACCESS_TOKEN", can you merge it too?

@leecalcote
Copy link
Member

Awesome. You bet.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-pick self-hosted commit to master branch
3 participants