Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Edit bash scripts for linkerd and osm #62

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

alphaX86
Copy link
Member

Signed-off-by: Aadhitya A aadhitya864@gmail.com

Description

This PR fixes #

Notes for Reviewers
Tests are being run. So, PR is WIP

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Aadhitya A <aadhitya864@gmail.com>
@alphaX86
Copy link
Member Author

alphaX86 commented Aug 30, 2022

Ok seems I found a tiny bug in the install script... maybe fixing that should resolve the trick
https://github.com/meshery/meshery.io/blob/58e355bea9e558f91bc152af4cc8c3eff8a35e06/install#L237

Update: Fixed and merged just now

@gyohuangxin
Copy link
Member

@alphaX86 Thanks for updating this.

Copy link
Member

@gyohuangxin gyohuangxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyohuangxin gyohuangxin merged commit cd8917e into layer5io:master Aug 31, 2022
@gyohuangxin
Copy link
Member

@alphaX86
Copy link
Member Author

alphaX86 commented Sep 1, 2022

@gyohuangxin I wonder if its the issue on OSM mesh adapter, could you confirm if its working fine on linkerd side?

@gyohuangxin
Copy link
Member

@alphaX86
Copy link
Member Author

alphaX86 commented Sep 1, 2022

Gotcha... So the issue is on osm adapter. I'll fix this in a new PR 👍

@gyohuangxin
Copy link
Member

@alphaX86 Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants