Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add more logs during the meshery installation. #65

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

gyohuangxin
Copy link
Member

Signed-off-by: Huang Xin xin1.huang@intel.com

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Huang Xin <xin1.huang@intel.com>
@gyohuangxin
Copy link
Member Author

I added more logs during meshery installation, so that we can check the meshery status and debug more easily.
@leecalcote @hershd23 @alphaX86

@gyohuangxin gyohuangxin merged commit a3417e2 into layer5io:master Sep 29, 2022
@hershd23
Copy link
Contributor

Great @gyohuangxin

@leecalcote
Copy link
Member

@Revolyssup @AugustasV fyi

@AugustasV
Copy link
Contributor

@leecalcote in my opinion there was no need to merge such changes into master.
It was enough just to change how pipeline is triggered inside fork and add those lines for testing there

@gyohuangxin
Copy link
Member Author

gyohuangxin commented Sep 29, 2022

@leecalcote in my opinion there was no need to merge such changes into master.

It was enough just to change how pipeline is triggered inside fork and add those lines for testing there

Yes, it was enough and we can use fork to test. However, when scheduled tests failed, these logs are helpful to track what happened. I think we can use these logs for a while then remove them when they are not needed.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants